#work
@@ -54,12 +44,10 @@ describe("Memo tag navigation", () => {
);
fireEvent.click(screen.getByText("#work"));
-
- expect(clearSelectedSpace).toHaveBeenCalledOnce();
expect(navigateTo).toHaveBeenCalledWith("/?filter=tagSearch%3Awork");
});
- it("returns a Profile-origin tag without clearing the remembered Space", () => {
+ it("returns a Profile-origin tag to that profile's memo list", () => {
origin.parentPage = "/u/alice?view=map";
render(
@@ -69,8 +57,6 @@ describe("Memo tag navigation", () => {
);
fireEvent.click(screen.getByText("#work"));
-
- expect(clearSelectedSpace).not.toHaveBeenCalled();
expect(navigateTo).toHaveBeenCalledWith("/u/alice?filter=tagSearch%3Awork");
});
});
diff --git a/web/tests/quick-find-navigation.test.tsx b/web/tests/quick-find-navigation.test.tsx
index 32d5ae4d..9da1ef2f 100644
--- a/web/tests/quick-find-navigation.test.tsx
+++ b/web/tests/quick-find-navigation.test.tsx
@@ -4,7 +4,7 @@ import { beforeEach, describe, expect, it, vi } from "vitest";
import QuickFindDialog from "@/components/AppSidebar/QuickFindDialog";
import MemoFilters from "@/components/MemoFilters";
import { AppSidebarProvider, useAppSidebar } from "@/contexts/AppSidebarContext";
-import { getSelectedSpaceStorageKey, SpaceProvider, useSpaceContext } from "@/contexts/SpaceContext";
+import { SpaceProvider, useSpaceContext } from "@/contexts/SpaceContext";
const state = vi.hoisted(() => ({
currentUser: { name: "users/alice" } as { name: string } | undefined,
@@ -35,6 +35,12 @@ vi.mock("@/hooks/useCurrentUser", () => ({
vi.mock("@/hooks/useSpaceQueries", () => ({
useSpaces: () => ({ data: state.spaces, isSuccess: true, isPending: false, isError: false }),
+ useSpace: (_user: string, name: string) => ({
+ data: state.spaces.find((space) => space.name === name),
+ isSuccess: true,
+ error: null,
+ refetch: vi.fn(),
+ }),
}));
vi.mock("@/hooks/useUserQueries", () => ({
@@ -163,22 +169,18 @@ describe("Quick Find navigation", () => {
expect(state.filters.filter((filter) => !predicate(filter))).toEqual([{ factor: "tagSearch", value: "work" }]);
});
- it("switches to All in one history step so Back returns directly to Inbox", async () => {
- const storageKey = getSelectedSpaceStorageKey("users/alice");
- sessionStorage.setItem(storageKey, "spaces/product");
-
+ it("searches from Inbox into global Home in one history step", async () => {
const router = renderSearch("/inbox");
- expect(screen.getByTestId("scope")).toHaveTextContent("spaces/product");
+ expect(screen.getByTestId("scope")).toHaveTextContent("all");
openQuickFind();
const input = await screen.findByRole("textbox");
fireEvent.change(input, { target: { value: "roadmap" } });
fireEvent.submit(input.closest("form")!);
await waitFor(() => expect(screen.getByTestId("path")).toHaveTextContent("/?filter=contentSearch%3Aroadmap"));
- expect(state.setFilters).toHaveBeenCalledWith([{ factor: "contentSearch", value: "roadmap" }]);
+ expect(state.setFilters).not.toHaveBeenCalled();
expect(screen.getByTestId("scope")).toHaveTextContent("all");
- expect(sessionStorage.getItem(storageKey)).toBeNull();
await act(async () => {
await router.navigate(-1);
@@ -187,10 +189,8 @@ describe("Quick Find navigation", () => {
expect(screen.getByTestId("path")).toHaveTextContent("/inbox");
});
- it("keeps a unique selected Space title compact in remembered-collection search", async () => {
- sessionStorage.setItem(getSelectedSpaceStorageKey("users/alice"), "spaces/product");
-
- renderSearch("/");
+ it("keeps a unique selected Space title compact in route-collection search", async () => {
+ renderSearch("/spaces/product");
openQuickFind();
const input = await screen.findByRole("textbox");
@@ -204,9 +204,7 @@ describe("Quick Find navigation", () => {
{ name: `spaces/${uuid}`, title: "Product", description: "" },
{ name: "spaces/product-roadmap", title: "Product", description: "" },
];
- sessionStorage.setItem(getSelectedSpaceStorageKey("users/alice"), `spaces/${uuid}`);
-
- renderSearch("/");
+ renderSearch(`/spaces/${uuid}`);
openQuickFind();
const input = await screen.findByRole("textbox");
diff --git a/web/tests/quick-find.test.ts b/web/tests/quick-find.test.ts
index 05b4a0ea..6ee5ccd2 100644
--- a/web/tests/quick-find.test.ts
+++ b/web/tests/quick-find.test.ts
@@ -22,7 +22,6 @@ describe("Quick Find", () => {
...scopedFilters.filter((filter) => filter.factor !== "contentSearch"),
{ factor: "celSearch", value: expression },
]);
- expect(submission.switchToAll).toBe(false);
});
it("replaces both kinds of search without dropping facets", () => {
@@ -66,11 +65,10 @@ describe("Quick Find", () => {
{ factor: "contentSearch", value: "project" },
],
destination: undefined,
- switchToAll: false,
});
});
- it("searches Archived as a user collection without clearing the remembered Space", () => {
+ it("searches Archived as a user collection", () => {
expect(resolveQuickFindSubmission("/archived", "project", scopedFilters, "text")).toEqual({
filters: [
{ factor: "tagSearch", value: "work" },
@@ -78,11 +76,10 @@ describe("Quick Find", () => {
{ factor: "contentSearch", value: "project" },
],
destination: undefined,
- switchToAll: false,
});
});
- it("keeps the remembered collection filters when searching from Attachments", () => {
+ it("keeps the collection filters when searching from Attachments", () => {
expect(resolveQuickFindSubmission("/attachments", "project", scopedFilters, "text")).toEqual({
filters: [
{ factor: "tagSearch", value: "work" },
@@ -90,11 +87,10 @@ describe("Quick Find", () => {
{ factor: "contentSearch", value: "project" },
],
destination: "/?filter=tagSearch%3Awork%2CdisplayTime%3A2026-08-03%2CcontentSearch%3Aproject",
- switchToAll: false,
});
});
- it("keeps the remembered collection on a normalized Attachments route", () => {
+ it("keeps the collection on a normalized Attachments route", () => {
expect(resolveQuickFindSubmission("/Attachments/", "project", scopedFilters, "text")).toEqual({
filters: [
{ factor: "tagSearch", value: "work" },
@@ -102,7 +98,6 @@ describe("Quick Find", () => {
{ factor: "contentSearch", value: "project" },
],
destination: "/?filter=tagSearch%3Awork%2CdisplayTime%3A2026-08-03%2CcontentSearch%3Aproject",
- switchToAll: false,
});
});
@@ -114,7 +109,6 @@ describe("Quick Find", () => {
{ factor: "contentSearch", value: "project" },
],
destination: "/u/steven?filter=tagSearch%3Awork%2CdisplayTime%3A2026-08-03%2CcontentSearch%3Aproject",
- switchToAll: false,
});
});
@@ -130,7 +124,6 @@ describe("Quick Find", () => {
expect(resolveQuickFindSubmission(pathname, "project", scopedFilters, "text")).toEqual({
filters: [{ factor: "contentSearch", value: "project" }],
destination: "/?filter=contentSearch%3Aproject",
- switchToAll: true,
});
});
diff --git a/web/tests/router-config.test.tsx b/web/tests/router-config.test.tsx
index 8a6b4d58..1d5d5601 100644
--- a/web/tests/router-config.test.tsx
+++ b/web/tests/router-config.test.tsx
@@ -1,9 +1,10 @@
import { isValidElement } from "react";
-import type { RouteObject } from "react-router-dom";
+import { matchRoutes, type RouteObject } from "react-router-dom";
import { describe, expect, it } from "vitest";
import { ROUTES, routeConfig } from "@/router";
import { RequireAuthRoute, RequireFullInitializationRoute, RequireGuestRoute, RequireInstanceInitializationRoute } from "@/router/guards";
-import { CALENDAR_ROUTE_PATTERN } from "@/router/routes";
+import { CALENDAR_ROUTE_PATTERN, SPACE_ROUTE_PATTERN } from "@/router/routes";
+import { SpaceRoute } from "@/router/SpaceRoute";
// Walk the nested route config and find the first route with the given path,
// starting from the provided roots. Returns undefined if nothing matches.
@@ -40,6 +41,23 @@ function hasAncestorOfType(routes: RouteObject[], path: string, guardType: unkno
}
describe("router configuration", () => {
+ it.each([
+ "/spaces/product",
+ "/spaces/product/explore",
+ "/spaces/product/calendar/2026/09",
+ "/spaces/product/attachments",
+ ])("gates %s with authentication and Space access", (path) => {
+ const types = matchRoutes(routeConfig, path)?.map(({ route }) => elementType(route));
+ expect(types).toContain(RequireAuthRoute);
+ expect(types).toContain(SpaceRoute);
+ expect(findByPath(routeConfig, SPACE_ROUTE_PATTERN)).toBeDefined();
+ });
+ it("keeps unknown Space subroutes outside collection pages", () => {
+ const matches = matchRoutes(routeConfig, "/spaces/product/unknown");
+ expect(matches?.at(-1)?.route.path).toBe("*");
+ expect(matches?.map(({ route }) => elementType(route))).not.toContain(SpaceRoute);
+ });
+
it("keeps /auth/callback outside the guest-only guard", () => {
// Regression guard for issue #5846 follow-up: an authenticated tab elsewhere
// must not short-circuit the OAuth callback via RequireGuestRoute.
diff --git a/web/tests/space-context.test.tsx b/web/tests/space-context.test.tsx
index f1844af6..20adb868 100644
--- a/web/tests/space-context.test.tsx
+++ b/web/tests/space-context.test.tsx
@@ -1,225 +1,97 @@
-import { create } from "@bufbuild/protobuf";
-import { fireEvent, render, screen, waitFor } from "@testing-library/react";
-import { MemoryRouter, useLocation } from "react-router-dom";
+import { act, fireEvent, render, screen } from "@testing-library/react";
+import { createMemoryRouter, Link, Outlet, RouterProvider, useLocation } from "react-router-dom";
import { beforeEach, describe, expect, it, vi } from "vitest";
-import { getSelectedSpaceStorageKey, SpaceProvider, useSpaceContext } from "@/contexts/SpaceContext";
-import { SpaceSchema } from "@/types/proto/api/v1/space_service_pb";
-
-const newlyCreatedSpace = create(SpaceSchema, { name: "spaces/new", title: "New", description: "" });
+import { SpaceProvider, useSpaceContext } from "@/contexts/SpaceContext";
+import { getSpaceSwitchPath } from "@/router/routes";
const state = vi.hoisted(() => ({
- currentUser: { name: "users/alice" } as { name: string } | undefined,
- query: {
- data: [] as Array<{ name: string; title: string; description: string }>,
- isSuccess: true,
- isPending: false,
- isError: false,
- },
+ user: "users/alice",
+ spaces: [
+ { name: "spaces/a", title: "Same" },
+ { name: "spaces/b", title: "Same" },
+ ],
+ ready: true,
}));
-
-vi.mock("@/hooks/useCurrentUser", () => ({
- default: () => state.currentUser,
-}));
-
+vi.mock("@/hooks/useCurrentUser", () => ({ default: () => ({ name: state.user }) }));
vi.mock("@/hooks/useSpaceQueries", () => ({
- useSpaces: () => state.query,
+ useSpaces: () => ({ data: state.spaces, isPending: false, isError: false }),
+ useSpace: (_user: string, name?: string) => ({
+ data: state.ready ? state.spaces.find((s) => s.name === name) : undefined,
+ isSuccess: state.ready,
+ error: null,
+ refetch: vi.fn(),
+ }),
}));
-
const Probe = () => {
- const {
- clearSelectedSpace,
- collectionScope,
- duplicateSpaceTitles,
- memoFilter,
- spaces,
- selectedSpace,
- selectedSpaceName,
- selectMemos,
- selectSpace,
- } = useSpaceContext();
- return (
-
-
-
-
-
-
-
-
-
-
-
-
- );
-};
-
-const CurrentPath = () => {
const location = useLocation();
- return ;
-};
-
-const renderProvider = (initialPath = "/explore") =>
- render(
-
-
-
-
- ,
+ const context = useSpaceContext();
+ return (
+ <>
+
+
+
+
+
+ B
+ Memos
+
+
);
-
-describe("SpaceProvider", () => {
+};
+const setup = (path = "/") => {
+ const router = createMemoryRouter(
+ [
+ {
+ path: "*",
+ element: (
+
+
+
+ ),
+ },
+ ],
+ { initialEntries: [path] },
+ );
+ render();
+ return router;
+};
+describe("URL-owned Space context", () => {
beforeEach(() => {
- sessionStorage.clear();
- state.currentUser = { name: "users/alice" };
- state.query = { data: [], isSuccess: true, isPending: false, isError: false };
+ state.ready = true;
+ state.user = "users/alice";
});
-
- it("uses the All collection when the user has no stored Space selection", () => {
- renderProvider();
-
- expect(screen.getByTestId("selected-name")).toHaveTextContent("Memos");
- expect(screen.getByTestId("collection-scope")).toHaveTextContent("all");
- expect(screen.getByTestId("memo-filter")).toHaveTextContent("all");
+ it("reads All on global pages", () => {
+ setup("/explore");
+ expect(screen.getByTestId("space")).toHaveTextContent("all");
+ expect(screen.getByTestId("filter")).toHaveTextContent("all");
});
-
- it("restores a valid Space and stores changes only for the current user", () => {
- const product = { name: "spaces/product", title: "Product", description: "" };
- state.query.data = [product];
- sessionStorage.setItem(getSelectedSpaceStorageKey("users/alice"), product.name);
- renderProvider();
-
- expect(screen.getByTestId("selected-name")).toHaveTextContent(product.name);
- expect(screen.getByTestId("selected-title")).toHaveTextContent("Product");
- expect(screen.getByTestId("collection-scope")).toHaveTextContent("space:spaces/product");
- expect(screen.getByTestId("memo-filter")).toHaveTextContent('space == "spaces/product"');
-
- fireEvent.click(screen.getByRole("button", { name: "Select Memos" }));
- expect(sessionStorage.getItem(getSelectedSpaceStorageKey("users/alice"))).toBeNull();
-
- fireEvent.click(screen.getByRole("button", { name: "Select first Space" }));
- expect(sessionStorage.getItem(getSelectedSpaceStorageKey("users/alice"))).toBe(product.name);
+ it("restores Space from a deep link before metadata has loaded", () => {
+ state.ready = false;
+ setup("/spaces/a/calendar/2026/09/06");
+ expect(screen.getByTestId("space")).toHaveTextContent("spaces/a");
+ expect(screen.getByTestId("filter")).toHaveTextContent('space == "spaces/a"');
+ expect(screen.getByTestId("ready")).toHaveTextContent("false");
});
-
- it("clears a stored selection only after a successful list proves it unavailable", async () => {
- const key = getSelectedSpaceStorageKey("users/alice");
- sessionStorage.setItem(key, "spaces/removed");
- renderProvider();
-
- await waitFor(() => expect(screen.getByTestId("selected-name")).toHaveTextContent("Memos"));
- expect(sessionStorage.getItem(key)).toBeNull();
+ it("preserves dates and filters through A, B, All and browser history", async () => {
+ const suffix = "/calendar/2026/09/06?filter=tagSearch%3Awork";
+ const router = setup(`/spaces/a${suffix}`);
+ fireEvent.click(screen.getByText("B"));
+ expect(screen.getByTestId("path").textContent).toBe(`/spaces/b${suffix}`);
+ expect(screen.getByTestId("space")).toHaveTextContent("spaces/b");
+ expect(screen.getByTestId("duplicates")).toHaveTextContent("Same");
+ fireEvent.click(screen.getByText("Memos"));
+ expect(screen.getByTestId("path").textContent).toBe(suffix);
+ await act(() => router.navigate(-1));
+ expect(screen.getByTestId("space")).toHaveTextContent("spaces/b");
+ await act(() => router.navigate(-1));
+ expect(screen.getByTestId("space")).toHaveTextContent("spaces/a");
+ await act(() => router.navigate(1));
+ expect(screen.getByTestId("space")).toHaveTextContent("spaces/b");
});
-
- it("preserves a stored selection when the Space list fails transiently", () => {
- const key = getSelectedSpaceStorageKey("users/alice");
- sessionStorage.setItem(key, "spaces/product");
- state.query = { data: [], isSuccess: false, isPending: false, isError: true };
- renderProvider();
-
- expect(screen.getByTestId("selected-name")).toHaveTextContent("spaces/product");
- expect(sessionStorage.getItem(key)).toBe("spaces/product");
- });
-
- it("keeps a newly created Space selected until the refreshed list includes it", () => {
- renderProvider();
-
- fireEvent.click(screen.getByRole("button", { name: "Select new Space" }));
-
- expect(screen.getByTestId("selected-name")).toHaveTextContent(newlyCreatedSpace.name);
- expect(screen.getByTestId("selected-title")).toHaveTextContent(newlyCreatedSpace.title);
- expect(screen.getByTestId("memo-filter")).toHaveTextContent('space == "spaces/new"');
- expect(sessionStorage.getItem(getSelectedSpaceStorageKey("users/alice"))).toBe(newlyCreatedSpace.name);
- });
-
- it("includes an optimistic selected Space when deriving matching titles", () => {
- state.query.data = [{ name: "spaces/existing-new", title: "New", description: "" }];
- renderProvider();
-
- fireEvent.click(screen.getByRole("button", { name: "Select new Space" }));
-
- expect(screen.getByTestId("duplicate-titles")).toHaveTextContent("New");
- });
-
- it.each(["/", "/explore", "/attachments"])("preserves the current collection route when switching to a Space from %s", (initialPath) => {
- const product = { name: "spaces/product", title: "Product", description: "" };
- state.query.data = [product];
- renderProvider(initialPath);
-
- fireEvent.click(screen.getByRole("button", { name: "Select first Space" }));
-
- expect(screen.getByTestId("selected-name")).toHaveTextContent(product.name);
- expect(screen.getByTestId("path").textContent).toBe(initialPath);
- });
-
- it.each(["/", "/explore", "/attachments"])("preserves the current collection route when switching to All from %s", (initialPath) => {
- const product = { name: "spaces/product", title: "Product", description: "" };
- state.query.data = [product];
- sessionStorage.setItem(getSelectedSpaceStorageKey("users/alice"), product.name);
- renderProvider(initialPath);
-
- fireEvent.click(screen.getByRole("button", { name: "Select Memos" }));
-
- expect(screen.getByTestId("selected-name")).toHaveTextContent("Memos");
- expect(screen.getByTestId("path").textContent).toBe(initialPath);
- });
-
- it.each([
- ["Select first Space", "/inbox"],
- ["Select first Space", "/archived?filter=tagSearch%3Awork"],
- ["Select Memos", "/u/alice"],
- ["Select Memos", "/archived?filter=tagSearch%3Awork"],
- ])("falls back to Home when using %s outside a collection route", (action, initialPath) => {
- const product = { name: "spaces/product", title: "Product", description: "" };
- state.query.data = [product];
- sessionStorage.setItem(getSelectedSpaceStorageKey("users/alice"), product.name);
- renderProvider(initialPath);
-
- fireEvent.click(screen.getByRole("button", { name: action }));
-
- expect(screen.getByTestId("path").textContent).toBe("/");
- });
-
- it("can select All on a resource route without navigating", () => {
- const product = { name: "spaces/product", title: "Product", description: "" };
- state.query.data = [product];
- sessionStorage.setItem(getSelectedSpaceStorageKey("users/alice"), product.name);
- renderProvider("/memos/123");
-
- fireEvent.click(screen.getByRole("button", { name: "Clear Space in place" }));
-
- expect(screen.getByTestId("collection-scope")).toHaveTextContent("all");
- expect(screen.getByTestId("path")).toHaveTextContent("/memos/123");
- expect(sessionStorage.getItem(getSelectedSpaceStorageKey("users/alice"))).toBeNull();
- });
-
- it("isolates the active selection across account changes", () => {
- const product = { name: "spaces/product", title: "Product", description: "" };
- const personal = { name: "spaces/personal", title: "Personal", description: "" };
- state.query.data = [product, personal];
- sessionStorage.setItem(getSelectedSpaceStorageKey("users/alice"), product.name);
- sessionStorage.setItem(getSelectedSpaceStorageKey("users/bob"), personal.name);
- const view = renderProvider();
-
- expect(screen.getByTestId("selected-name")).toHaveTextContent(product.name);
-
- state.currentUser = { name: "users/bob" };
- view.rerender(
-
-
-
-
- ,
- );
-
- expect(screen.getByTestId("selected-name")).toHaveTextContent(personal.name);
+ it.each(["/memos/123", "/archived", "/inbox", "/setting", "/u/alice"])("keeps %s global and switches to Space Home", (path) => {
+ setup(`${path}?filter=tagSearch%3Awork`);
+ expect(screen.getByTestId("space")).toHaveTextContent("all");
+ fireEvent.click(screen.getByText("B"));
+ expect(screen.getByTestId("path").textContent).toBe("/spaces/b");
});
});
diff --git a/web/tests/space-queries.test.tsx b/web/tests/space-queries.test.tsx
index 05bfc3bd..45279fb0 100644
--- a/web/tests/space-queries.test.tsx
+++ b/web/tests/space-queries.test.tsx
@@ -1,4 +1,5 @@
import { create } from "@bufbuild/protobuf";
+import { Code, ConnectError } from "@connectrpc/connect";
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
import { act, renderHook, waitFor } from "@testing-library/react";
import type { ReactNode } from "react";
@@ -12,6 +13,7 @@ import {
useDeleteSpace,
useDeleteSpaceInvitation,
useDeleteSpaceMember,
+ useSpace,
useSpaceInvitations,
useSpaceMembers,
useSpaces,
@@ -32,6 +34,7 @@ const clients = vi.hoisted(() => ({
listSpaceInvitations: vi.fn(),
listSpaceMembers: vi.fn(),
listSpaces: vi.fn(),
+ getSpace: vi.fn(),
listUserSpaceInvitations: vi.fn(),
updateSpace: vi.fn(),
updateSpaceMember: vi.fn(),
@@ -65,6 +68,35 @@ describe("Space queries", () => {
}
});
+ it("fetches the route Space with viewer-isolated cache entries", async () => {
+ clients.getSpace.mockResolvedValue(create(SpaceSchema, { name: SPACE_NAME, title: "Product" }));
+ const client = createQueryClient();
+ const view = renderHook(({ user }) => useSpace(user, SPACE_NAME), { initialProps: { user: VIEWER }, wrapper: createWrapper(client) });
+ await waitFor(() => expect(view.result.current.isSuccess).toBe(true));
+ expect(clients.getSpace).toHaveBeenCalledWith({ name: SPACE_NAME });
+ clients.getSpace.mockRejectedValue(new ConnectError("not found", Code.NotFound));
+ view.rerender({ user: OTHER_VIEWER });
+ expect(view.result.current.data).toBeUndefined();
+ await waitFor(() => expect(view.result.current.isError).toBe(true));
+ expect(clients.getSpace).toHaveBeenCalledTimes(2);
+ });
+
+ it("refetches an active Space after leaving and exposes the access failure", async () => {
+ const client = createQueryClient();
+ const member = create(SpaceMemberSchema, { name: `${SPACE_NAME}/members/test`, user: VIEWER });
+ client.setQueryData(spaceKeys.members(VIEWER, SPACE_NAME), [member]);
+ clients.getSpace.mockResolvedValue(create(SpaceSchema, { name: SPACE_NAME, title: "Product" }));
+ clients.deleteSpaceMember.mockResolvedValue({});
+ const view = renderHook(() => ({ space: useSpace(VIEWER, SPACE_NAME), leave: useDeleteSpaceMember(VIEWER) }), {
+ wrapper: createWrapper(client),
+ });
+ await waitFor(() => expect(view.result.current.space.isSuccess).toBe(true));
+ clients.getSpace.mockRejectedValue(new ConnectError("not found", Code.NotFound));
+ await act(() => view.result.current.leave.mutateAsync({ name: member.name }));
+ await waitFor(() => expect(view.result.current.space.isError).toBe(true));
+ expect(view.result.current.space.data).toBeUndefined();
+ });
+
it("loads every page so the switcher can show all available Spaces", async () => {
clients.listSpaces
.mockResolvedValueOnce({
@@ -224,7 +256,7 @@ describe("Space queries", () => {
});
expect(clients.deleteSpace).toHaveBeenCalledWith({ name: SPACE_NAME });
expect(queryClient.getQueryData(spaceKeys.list(VIEWER))).toEqual([createdSpace]);
- expect(queryClient.getQueryState(spaceKeys.members(VIEWER, SPACE_NAME))).toBeUndefined();
+ expect(queryClient.getQueryData(spaceKeys.members(VIEWER, SPACE_NAME))).toBeUndefined();
});
it("synchronizes admin invitation caches after create and delete", async () => {
@@ -374,6 +406,6 @@ describe("Space queries", () => {
});
expect(clients.deleteSpaceMember).toHaveBeenLastCalledWith({ name: viewerMember.name });
expect(queryClient.getQueryData(spaceKeys.list(VIEWER))).toEqual([]);
- expect(queryClient.getQueryState(spaceKeys.members(VIEWER, SPACE_NAME))).toBeUndefined();
+ expect(queryClient.getQueryData(spaceKeys.members(VIEWER, SPACE_NAME))).toBeUndefined();
});
});
diff --git a/web/tests/space-routes.test.tsx b/web/tests/space-routes.test.tsx
new file mode 100644
index 00000000..e6fab18a
--- /dev/null
+++ b/web/tests/space-routes.test.tsx
@@ -0,0 +1,131 @@
+import { Code, ConnectError } from "@connectrpc/connect";
+import { fireEvent, render, screen } from "@testing-library/react";
+import { MemoryRouter, Route, Routes } from "react-router-dom";
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import { resolveQuickFindSubmission } from "@/components/AppSidebar/QuickFindDialog";
+import { getRouteActionPolicy, getSidebarRouteKind } from "@/components/AppSidebar/routes";
+import { CalendarHeader } from "@/components/CalendarView/CalendarHeader";
+import { resolveMemoDetailOrigin, resolveMemoOrigin } from "@/components/MemoView/navigation";
+import Calendar from "@/pages/Calendar";
+import { buildCollectionPath, getSpaceSwitchPath, resolveCollectionRoute } from "@/router/routes";
+import { SpaceRoute } from "@/router/SpaceRoute";
+
+const state = vi.hoisted(() => ({
+ selectedSpaceName: "spaces/a",
+ isSpaceReady: false,
+ spaceError: null as ConnectError | null,
+ retrySpace: vi.fn(),
+}));
+vi.mock("@/contexts/SpaceContext", () => ({ useSpaceContext: () => state }));
+vi.mock("@/utils/i18n", async (original) => ({
+ ...(await original()),
+ useTranslate: () => (key: string) => key,
+}));
+vi.mock("@/components/CalendarView/CalendarView", () => ({ CalendarView: () => calendar content
}));
+
+beforeEach(() => {
+ state.isSpaceReady = false;
+ state.spaceError = null;
+ state.retrySpace.mockClear();
+});
+describe("Space route contract", () => {
+ it.each([
+ ["/spaces/a", "home"],
+ ["/spaces/a/explore", "explore"],
+ ["/spaces/a/calendar/2026/09/06", "calendar"],
+ ["/spaces/a/attachments", "attachments"],
+ ["/spaces/a/archived", "common"],
+ ["/spaces/a/unknown", "common"],
+ ])("classifies %s as %s", (path, kind) => expect(getSidebarRouteKind(path)).toBe(kind));
+ it("does not interpret unknown space routes or encoded slashes as global collections", () => {
+ expect(resolveCollectionRoute("/spaces/a/unknown").isCollection).toBe(false);
+ expect(resolveCollectionRoute("/spaces/a/archived").spaceName).toBeUndefined();
+ expect(resolveCollectionRoute("/spaces/a%2Fb").isCollection).toBe(false);
+ expect(resolveCollectionRoute("/spaces/A").spaceName).toBe("spaces/A");
+ expect(buildCollectionPath("/calendar/2026/09", "spaces/A")).toBe("/spaces/A/calendar/2026/09");
+ });
+ it("preserves collection parameters but drops unrelated global page parameters on switching", () => {
+ expect(getSpaceSwitchPath({ pathname: "/spaces/a/explore", search: "?filter=tagSearch%3Ax" }, "spaces/b")).toBe(
+ "/spaces/b/explore?filter=tagSearch%3Ax",
+ );
+ expect(getSpaceSwitchPath({ pathname: "/setting", search: "?section=spaces" }, "spaces/b")).toBe("/spaces/b");
+ });
+ it("searches from calendar and attachments into the same Space Home", () => {
+ for (const path of ["/spaces/a/calendar/2026/09", "/spaces/a/attachments"]) {
+ expect(resolveQuickFindSubmission(path, "roadmap", [], "text").destination).toBe("/spaces/a?filter=contentSearch%3Aroadmap");
+ }
+ expect(getRouteActionPolicy("/memos/a").searchDestination).toBe("/");
+ });
+ it("carries the full calendar origin through a permanent memo link", () => {
+ const parentPage = "/spaces/a/calendar/2026/09/06?filter=tagSearch%3Awork";
+ expect(
+ resolveMemoOrigin({ pathname: "/spaces/a/calendar/2026/09/06", search: "?filter=tagSearch%3Awork", memoName: "memos/x" }),
+ ).toEqual({ parentPage, parentScope: "preserve" });
+ expect(resolveMemoDetailOrigin({ from: parentPage })).toEqual({ parentPage, parentScope: "preserve" });
+ expect(resolveMemoDetailOrigin(undefined)).toEqual({ parentPage: "/", parentScope: "all" });
+ });
+});
+
+describe("Space page availability", () => {
+ const setup = () =>
+ render(
+
+
+ }>
+ space content} />
+
+
+ ,
+ );
+ it("withholds content while loading", () => {
+ setup();
+ expect(screen.queryByText("space content")).toBeNull();
+ expect(screen.getByRole("status")).toHaveTextContent("space.loading");
+ });
+ it("renders content only after membership resolves", () => {
+ state.isSpaceReady = true;
+ setup();
+ expect(screen.getByText("space content")).toBeInTheDocument();
+ });
+ it.each([Code.NotFound, Code.PermissionDenied])("shows the same unavailable state for code %s", (code) => {
+ state.spaceError = new ConnectError("unavailable", code);
+ setup();
+ expect(screen.getByRole("status")).toHaveTextContent("space.unavailable");
+ expect(screen.getByRole("link", { name: "space.back-to-memos" })).toHaveAttribute("href", "/");
+ expect(screen.queryByText("space content")).toBeNull();
+ });
+ it("offers retry for a transient failure", () => {
+ state.spaceError = new ConnectError("offline", Code.Unavailable);
+ setup();
+ fireEvent.click(screen.getByRole("button", { name: "search.retry" }));
+ expect(state.retrySpace).toHaveBeenCalledOnce();
+ });
+});
+
+describe("Space calendar navigation", () => {
+ it("keeps Space and filters in month links", () => {
+ render(
+
+
+ ,
+ );
+ expect(screen.getByRole("link", { name: "common.next-month" })).toHaveAttribute(
+ "href",
+ "/spaces/a/calendar/2026/10?filter=tagSearch%3Awork",
+ );
+ expect(screen.getByRole("link", { name: "common.previous-month" })).toHaveAttribute(
+ "href",
+ "/spaces/a/calendar/2026/08?filter=tagSearch%3Awork",
+ );
+ });
+ it("resolves an incomplete Space calendar address inside the Space", async () => {
+ render(
+
+
+ } />
+
+ ,
+ );
+ expect(await screen.findByText("calendar content")).toBeInTheDocument();
+ });
+});
diff --git a/web/tests/space-switcher.test.tsx b/web/tests/space-switcher.test.tsx
index 7aa32cfd..8f3d7a19 100644
--- a/web/tests/space-switcher.test.tsx
+++ b/web/tests/space-switcher.test.tsx
@@ -1,4 +1,5 @@
-import { fireEvent, render, screen, waitFor, within } from "@testing-library/react";
+import { createEvent, fireEvent, screen, render as testingRender, waitFor, within } from "@testing-library/react";
+import { createMemoryRouter, MemoryRouter, RouterProvider } from "react-router-dom";
import { beforeEach, describe, expect, it, vi } from "vitest";
import SpaceSwitcher from "@/components/AppSidebar/SpaceSwitcher";
@@ -9,7 +10,6 @@ const spaceState = vi.hoisted(() => ({
],
selectedSpace: undefined as { name: string; title: string; description: string } | undefined,
selectedSpaceName: undefined as string | undefined,
- selectMemos: vi.fn(),
selectSpace: vi.fn(),
}));
@@ -49,6 +49,8 @@ vi.mock("@/utils/i18n", () => ({
useTranslate: () => (key: string) => key,
}));
+const render = (ui: React.ReactNode) => testingRender({ui});
+
describe("SpaceSwitcher", () => {
beforeEach(() => {
spaceState.spaces = [
@@ -57,10 +59,29 @@ describe("SpaceSwitcher", () => {
];
spaceState.selectedSpace = undefined;
spaceState.selectedSpaceName = undefined;
- spaceState.selectMemos.mockClear();
spaceState.selectSpace.mockClear();
});
+ it.each([
+ "/",
+ "/setting",
+ "/memos/direct",
+ ])("does not navigate the current scope from %s and leaves modified clicks native", async (path) => {
+ const router = createMemoryRouter([{ path: "*", element: }], { initialEntries: [path] });
+ testingRender();
+ const key = router.state.location.key;
+ fireEvent.click(screen.getByRole("button", { name: "space.switch: common.memos" }));
+ fireEvent.click(await screen.findByRole("menuitemradio", { name: "Memos" }));
+ expect(router.state.location.key).toBe(key);
+ await waitFor(() => expect(screen.queryByRole("menu")).not.toBeInTheDocument());
+ fireEvent.click(screen.getByRole("button", { name: "space.switch: common.memos" }));
+ const product = await screen.findByRole("menuitemradio", { name: "Product" });
+ const click = createEvent.click(product, { ctrlKey: true, cancelable: true });
+ fireEvent(product, click);
+ expect(click.defaultPrevented).toBe(false);
+ expect(router.state.location.pathname).toBe(path);
+ });
+
it("lists Memos, every available Space, and the create entry", async () => {
render();
@@ -205,18 +226,18 @@ describe("SpaceSwitcher", () => {
expect(researchRow).not.toHaveTextContent("research-space");
});
- it("switches context without navigation and opens Space creation", async () => {
+ it("links to spaces and opens Space creation", async () => {
render();
fireEvent.click(screen.getByRole("button", { name: "space.switch: common.memos" }));
- fireEvent.click(await screen.findByRole("menuitemradio", { name: "Product" }));
- expect(spaceState.selectSpace).toHaveBeenCalledWith(spaceState.spaces[0]);
+ const product = await screen.findByRole("menuitemradio", { name: "Product" });
+ expect(product).toHaveAttribute("href", "/spaces/product");
+ fireEvent.click(product);
await waitFor(() => expect(screen.queryByRole("menu")).not.toBeInTheDocument());
// Selecting Memos is how a signed-in user gets back to the home feed.
fireEvent.click(screen.getByRole("button", { name: "space.switch: common.memos" }));
fireEvent.click(await screen.findByRole("menuitemradio", { name: "Memos" }));
- expect(spaceState.selectMemos).toHaveBeenCalledOnce();
await waitFor(() => expect(screen.queryByRole("menu")).not.toBeInTheDocument());
fireEvent.click(screen.getByRole("button", { name: "space.switch: common.memos" }));