system/memos
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

chore: implement read-write lock for owner cache

Browse source
This commit is contained in:
Steven 2026-01-22 22:11:47 +08:00
parent edcddf3c95
commit 501e8f1eae
1 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
server/router/api/v1/instance_service.go
View file

@ -3,6 +3,7 @@ package v1
import ( import (
"context" "context"
"fmt" "fmt"
"sync"
"github.com/pkg/errors" "github.com/pkg/errors"
"google.golang.org/grpc/codes" "google.golang.org/grpc/codes"
@ -269,9 +270,25 @@ func convertInstanceMemoRelatedSettingToStore(setting *v1pb.InstanceSetting_Memo
} }
} }
var ownerCache *v1pb.User var (
ownerCache *v1pb.User
ownerCacheMutex sync.RWMutex
)
func (s *APIV1Service) GetInstanceOwner(ctx context.Context) (*v1pb.User, error) { func (s *APIV1Service) GetInstanceOwner(ctx context.Context) (*v1pb.User, error) {
// Try read lock first for cache hit
ownerCacheMutex.RLock()
if ownerCache != nil {
defer ownerCacheMutex.RUnlock()
return ownerCache, nil
}
ownerCacheMutex.RUnlock()
// Upgrade to write lock to populate cache
ownerCacheMutex.Lock()
defer ownerCacheMutex.Unlock()
// Double-check after acquiring write lock
if ownerCache != nil { if ownerCache != nil {
return ownerCache, nil return ownerCache, nil
} }
@ -294,5 +311,7 @@ func (s *APIV1Service) GetInstanceOwner(ctx context.Context) (*v1pb.User, error)
// ClearInstanceOwnerCache clears the cached instance owner. // ClearInstanceOwnerCache clears the cached instance owner.
// This should be called when an admin user is created or when the owner changes. // This should be called when an admin user is created or when the owner changes.
func (*APIV1Service) ClearInstanceOwnerCache() { func (*APIV1Service) ClearInstanceOwnerCache() {
ownerCacheMutex.Lock()
defer ownerCacheMutex.Unlock()
ownerCache = nil ownerCache = nil
} }